Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching prompting of hostname to absolute URL #16

Closed
jhvst opened this issue Nov 19, 2014 · 2 comments
Closed

Switching prompting of hostname to absolute URL #16

jhvst opened this issue Nov 19, 2014 · 2 comments
Labels
template

Comments

@jhvst
Copy link
Owner

jhvst commented Nov 19, 2014

Enabling SSL is currently undocumented as of pull request #15. Since hostname is actually not used anywhere besides of feeds and password recovery (which both use web addresses anyway), it could be worth updating the installation wizard and settings template to prompt for the complete URL path instead.
@jhvst jhvst added the template label Nov 19, 2014
@jayrox
Copy link
Collaborator

jayrox commented Nov 20, 2014

you could certainly ask for an absolute url from the start but i would still keep the check before making assumptions.

jhvst added a commit that referenced this issue Nov 20, 2014
@jhvst
Merge pull request #17 from jayrox/master
5740612 
update template files to ask for absolute URL #16
@jhvst
Copy link
Owner Author

jhvst commented Nov 20, 2014

Thanks for the PR!

What you mean by "keep the check before making assumptions"?

Anyway, the current code is fine in my opinion.

@jhvst jhvst closed this as completed Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
template
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayrox @jhvst