Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handler and submit button #34

Closed
ghost opened this issue May 15, 2015 · 5 comments
Closed

error handler and submit button #34

ghost opened this issue May 15, 2015 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented May 15, 2015

when I direct myself towards a unknown page such as http://example.com/sdfdsfasd, I begin see a blank page which a 404 naturally should really be displayed instead and other errors such as 200, 401, 500 etc. Martini should have this built-in so idk why it's not rendering via vertigo. Another thing is when writting a post, I'd recommend some sort of submit button.

jhvst added a commit that referenced this issue May 16, 2015
@jhvst
Copy link
Owner

jhvst commented May 16, 2015

The 404 error handler should now work.

You can submit a post by pressing enter on the title when you are done. This is basic browser behavior, which is supported by every device I've tested it with.

Having no visible submit button is ultimately a tradeoff between looks and what's natural to the user. Given that most users seem to be unaware of the enter-to-submit behavior, I guess I need to add the submit button back to the page.

@jhvst
Copy link
Owner

jhvst commented May 16, 2015

That being said, what's your input on this? Also, @jayrox, I'd value your opinion on this.

@jhvst jhvst removed the bug label May 16, 2015
@ghost
Copy link
Author

ghost commented May 16, 2015

@9uuso I mean the atmosphere of not having a submit button is great but within a few hours of first using vertigo I was having a rough time attempting to save the my newly written article, so the atmosphere of having a submission button is better for now.

@jhvst
Copy link
Owner

jhvst commented May 16, 2015

Alright, I'll add the submit button for the sake of convenience.

@jayrox
Copy link
Collaborator

jayrox commented May 16, 2015

i'd suggest a submit button. its not obvious to many users that hitting enter on the subject would submit the post, myself included.

@jhvst jhvst closed this as completed in 761be29 May 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants