Removed recursion from accumulateParents

jhy · Jan 23, 2023 · e3e2c6b · e3e2c6b
1 parent 075b0e6
commit e3e2c6b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/main/java/org/jsoup/nodes/Element.java b/src/main/java/org/jsoup/nodes/Element.java
@@ -276,9 +276,9 @@ public Elements parents() {
 
     private static void accumulateParents(Element el, Elements parents) {
         Element parent = el.parent();
-        if (parent != null && !parent.isNode("#root")) {
+        while (parent != null && !parent.isNode("#root")) {
             parents.add(parent);
-            accumulateParents(parent, parents);
+            parent = parent.parent();
         }
     }
 

diff --git a/src/test/java/org/jsoup/nodes/ElementTest.java b/src/test/java/org/jsoup/nodes/ElementTest.java
@@ -256,6 +256,10 @@ public void testGetParents() {
         assertEquals("div", parents.get(1).tagName());
         assertEquals("body", parents.get(2).tagName());
         assertEquals("html", parents.get(3).tagName());
+
+        Element orphan = new Element("p");
+        Elements none = orphan.parents();
+        assertEquals(0, none.size());
     }
 
     @Test