You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would suggest to add the embedding travis status image to Readme.md so that visitors would get this information.
I just cloned this repository to begin my code review journey as I believe there is much for me to learn from this popular project, however I just find one of the unittests failed :(
It's not a big deal but I would submit this suggestion with low priority.
The text was updated successfully, but these errors were encountered:
Thanks for your consideration. I just synced latest code from jsoup and run all the tests, there is one and only one failed. org.jsoup.integration.ConnectTest.postFiles
Not sure whether this test is dependent on environment factors like OS and etc. I am using Windows 7 X64, JDK1.8_192X64, IDEA 2018.3.2
org.junit.ComparisonFailure:
Expected :43963
Actual :43972
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at org.jsoup.integration.ConnectTest.postFiles(ConnectTest.java:304)
So that must mean in your checkout, the newlines in the test HTML file where converted from LF to CRLF, and so the file posted does not match its expected file size. I thought I had fixed .gitattributes (in 47a7f5a) to correct for that, but I guess not. I'll have another shot at it.
I would suggest to add the embedding travis status image to Readme.md so that visitors would get this information.
I just cloned this repository to begin my code review journey as I believe there is much for me to learn from this popular project, however I just find one of the unittests failed :(
It's not a big deal but I would submit this suggestion with low priority.
The text was updated successfully, but these errors were encountered: