Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add travis status image to Readme.md #1156

Closed
ny83427 opened this issue Dec 12, 2018 · 3 comments
Closed

Suggestion: Add travis status image to Readme.md #1156

ny83427 opened this issue Dec 12, 2018 · 3 comments

Comments

@ny83427
Copy link
Contributor

ny83427 commented Dec 12, 2018

I would suggest to add the embedding travis status image to Readme.md so that visitors would get this information.

I just cloned this repository to begin my code review journey as I believe there is much for me to learn from this popular project, however I just find one of the unittests failed :(

It's not a big deal but I would submit this suggestion with low priority.

@jhy
Copy link
Owner

jhy commented Dec 24, 2018

Thanks, good idea. Are you still getting a build failure, BTW? All green for me.

9934dfc

@jhy jhy closed this as completed Dec 24, 2018
@ny83427
Copy link
Contributor Author

ny83427 commented Dec 24, 2018

Thanks for your consideration. I just synced latest code from jsoup and run all the tests, there is one and only one failed. org.jsoup.integration.ConnectTest.postFiles

Not sure whether this test is dependent on environment factors like OS and etc. I am using Windows 7 X64, JDK1.8_192X64, IDEA 2018.3.2

image

org.junit.ComparisonFailure:
Expected :43963
Actual :43972

at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at org.jsoup.integration.ConnectTest.postFiles(ConnectTest.java:304)

@jhy
Copy link
Owner

jhy commented Dec 27, 2018

So that must mean in your checkout, the newlines in the test HTML file where converted from LF to CRLF, and so the file posted does not match its expected file size. I thought I had fixed .gitattributes (in 47a7f5a) to correct for that, but I guess not. I'll have another shot at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants