Don't use default locale when lowercasing #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the default locale is set to Turkish, "I".toLowerCase() returns "ı", the dotless I. The method toLowerCase() is used throughout the code to normalize values. But none of these should be locale-sensitive. That's why right now all the added tests are failing.
|
Thanks! Looks great. |
|
BTW @cketti I really appreciate the thoroughness of this implementation, particularly the testing, and the cleanliness of the static import. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.toLowerCase()uses the default locale for the case conversion. This can lead to undesired results when using the Turkish locale (see the blog post linked in issue #256).This pull request adds some tests to make sure jsoup's behavior is independent of the default locale.
MultiLocaleRuleruns every test annotated with@MultiLocaleTesttwice. Once withLocale.ENGLISHas the default locale and once with Turkish as the default value.This does not fix content matching issues with non-ASCII data, e.g. the one described in issue #474. However, it now consistently fails independent of the default locale.
Fixes #256