Incorrect results with rebinning

[bghani]

Hi there,

First of all thank you for the package. I am trying to rebin but I am getting incorroct results:

So my data looks like:

x_old is [1.5 2.5 3.5 4.5 5.5 6.5]
y_old is [10 10 10 10 10]
x_new is [1.7 2.27332857 2.84665714 3.41998571 3.99331429 4.56664286
5.13997143 5.7133]
The y_new I get on using your script is:

[ 55.73328571 5.73328571 5.73328571 5.73328571 5.73328571 5.73328571 5.73328571]

There is clearly some problem with this result especially with the first bin result. Could you have some hints on what could be going wrong?

I am using the assumption of 'piecewise_constant' for bins.

Thank you so much!

Burooj

[andyfaff]

I can confirm this. I'll have a look into it.

[jhykes]

It looks like the trigger for this is the 1.7 new lower bound which is above the old lower bound 1.5. If I adjust the new lower bound to 1.5 or lower, the results look okay.

I'm not sure when I'll have time to fix this.

Here is a script to repeat this calculation:

import numpy as np                                                    
import rebin                                                          
                                                                      
x_old = np.array([1.5, 2.5, 3.5, 4.5, 5.5, 6.5])                      
                                                                      
y_old = np.array([10., 10., 10., 10., 10.])                           
                                                                      
x_new = np.array([1.7, 2.27332857, 2.84665714, 3.41998571, 3.99331429,
                  4.56664286, 5.13997143, 5.7133 ])                   
                                                                      
y_new = rebin.rebin(x_old, y_old, x_new, 'piecewise_constant')        
                                                                      
print(y_new)                                                          

[bghani]

Thank you for your feedback. So you mean there is an error in the code?

[andyfaff]

There's a bug in the code. I have a fix for when there's no uncertainty, but still working on the fix for with uncertainty.

…

On Tue., 18 Jun. 2019, 19:37 buroojg, ***@***.***> wrote: Thank you for your feedback. So you mean there is an error in the code? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9?email_source=notifications&email_token=AAFLTVVA7MWMPOJFRVLO7UTP3CUGJA5CNFSM4HXZQ6DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX5ZW6I#issuecomment-503028601>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFLTVR776YQYIKQH6G4WF3P3CUGJANCNFSM4HXZQ6DA> .

[bghani]

Alright, thanks a lot. Would it be possible for you to share the code for when there's no uncertainty in the meantime?

[endolith]

So is this fixed?

[bghani]

Yes, it is.

[endolith]

So why is it still Open? :)

[andyfaff]

I think was fixed in #10

[jhykes]

Thanks guys for confirming that this is fixed! Closing the issue now...