Handle str-typed empty return from readframes. #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a [bug](http://bugs.python.org/issue24608) in python3.4's `wave` library that leads to `readframes()` returning a str (specifically `''`), not bytes. This leads to a crash when trying to pass data back to `writeframes()`. This is a workaround to the problem.
jiaaro
added a commit
that referenced
this pull request
Jul 14, 2015
Handle str-typed empty return from readframes.
|
Thanks, very strange bug - I'll add a comment explaining the line too |
|
This bug fix is available in v0.14.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in python3.4's
wavelibrary that leads toreadframes()returning a str (specifically''), not bytes.This leads to a crash when trying to pass data back to
writeframes().This is a workaround to the problem.