Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat log messages, switch from warn to err #24

Merged
merged 1 commit into from
May 29, 2024

Conversation

smlavine
Copy link
Contributor

These logs are followed by the return of an error value -- most likely,
a user of this library will follow this call by exiting the program. It
is better that an end user sees these messages marked as "error" rather
than "warning".

The messages themselves have been slightly reformatted to make them
easier to read for the end user.

These logs are followed by the return of an error value -- most likely,
a user of this library will follow this call by exiting the program. It
is better that an end user sees these messages marked as "error" rather
than "warning".

The messages themselves have been slightly reformatted to make them
easier to read for the end user.
Copy link
Owner

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jiacai2050 jiacai2050 merged commit f591095 into jiacai2050:main May 29, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants