This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Fix fullscreen not working + menu refactor (fix #1206) #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronjouch
approved these changes
Jun 3, 2021
ronjouch
changed the title
ronjouch
approved these changes
Jun 4, 2021
ronjouch
added a commit
that referenced
this pull request
Jun 7, 2021
``` Uncaught Exception: TypeError: Cannot read property 'show' of undefined at App.<anonymous> (/src/main.ts:177:18) ``` Seems like an oversight of the recent refactor. * macOS: fix crash on activating main window (fix #1210) * Eliminate need for global mainWindow, refactor widevine / non-widevine events (#1218) Co-authored-by: Adam Weeden <adamweeden@gmail.com>
Adam777Z
pushed a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
…ivefier#1210) * Catch promise errors better * Move subFunctions to bottom of createNewWindow * Use parents when creating child BrowserWindow instances * Some about:blank pages have an anchor (for some reason) * Inject browserWindowOptions better * Interim refactor to MainWindow object * Split up the window functions/helpers/events some * Further separate out window functions + tests * Add a mock for unit testing functions that access electron * Add unit tests for onWillPreventUnload * Improve windowEvents tests * Add the first test for windowHelpers * Move WebRequest event handling to node * insertCSS completely under test * clearAppData completely under test * Fix contextMenu require bug * More tests + fixes * Fix + add to createNewTab tests * Convert createMainWindow back to func + work out gremlins * Move setupWindow away from main since its shared * Make sure contextMenu is handling promises * Fix issues with fullscreen not working + menu refactor * Run jest against app/dist so that we can hit app unit tests as well * Requested PR changes
Adam777Z
pushed a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
…ativefier#1213) ``` Uncaught Exception: TypeError: Cannot read property 'show' of undefined at App.<anonymous> (/src/main.ts:177:18) ``` Seems like an oversight of the recent refactor. * macOS: fix crash on activating main window (fix nativefier#1210) * Eliminate need for global mainWindow, refactor widevine / non-widevine events (nativefier#1218) Co-authored-by: Adam Weeden <adamweeden@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1206