Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

With latest version, links are opening up in Safari even though my default browser is Chrome #691

Closed
xiaogwu opened this issue Sep 25, 2018 · 2 comments

Comments

@xiaogwu
Copy link

xiaogwu commented Sep 25, 2018

I upgrade nativefier to version 7.6.7 and have noticed that all links I click will now open in Safari versus my default browser Chrome.

I have an older version of my "app" and it open links in Chrome still.

Not sure if it's a flag setting now to specify which browser to use?

@bacongravy
Copy link
Contributor

It might be helpful if you could tell us what version you were using previously.

The code that opens the external links uses the shell.openExternal function from electron, here:

https://github.com/jiahaog/nativefier/blob/master/app/src/components/mainWindow/mainWindow.js#L204

and here:

https://github.com/jiahaog/nativefier/blob/master/app/src/components/contextMenu/contextMenu.js#L12

The shell.openExternal function is documented here:

https://github.com/electron/electron/blob/master/docs/api/shell.md

If it is not opening links in your default browser then perhaps this is a bug in electron?

@xiaogwu
Copy link
Author

xiaogwu commented Sep 25, 2018

Actually I figured out what needs to be done. Need to use the --internal-url flag. This can be closed.

@xiaogwu xiaogwu closed this as completed Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants