Fix crash on android 14 #647
Open
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be really useful to have a release with this PR included 🙏 |
saghul
reviewed
Mar 12, 2024
| @@ -177,7 +177,7 @@ public synchronized void register() throws IllegalStateException { | |||
| // avoid acquiring intent data failed in receiver on Android12 | |||
| // when using PendingIntent.FLAG_IMMUTABLE | |||
| // because it means Intent can't be modified anywhere -- jiangdg/20220929 | |||
| int PENDING_FLAG_IMMUTABLE = 1<<25; | |||
| int PENDING_FLAG_IMMUTABLE = 0x04000000; | |||
|
@jiangdongguo can you release a new version with this fix? Without it its impossible to use on Android 14. |
saghul
added a commit
to react-native-webrtc/react-native-webrtc
that referenced
this pull request
Mar 12, 2024
saghul
added a commit
to react-native-webrtc/react-native-webrtc
that referenced
this pull request
Mar 12, 2024
|
Gentle ping :-) |
|
when will this PR is going to merge any idea? |
|
@joaompneves any update on the new release fix for android 14? |
|
Hi @joaompneves, this is a great change! How can I use this version on another project while this isn't merged? |
|
You need to build the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Android 14, registerReceiver fails because its now missing and extra flag. This PR fixes that behavior.
Tested on an Android 14 device.