Fixed the shared key creds issue. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
force-pushed
the
dev_storage-tests
branch
3 times, most recently
from
13e380b
to
ec36646
Compare
sima-zhu
force-pushed
the
dev_storage-tests
branch
from
ec36646
to
1b8da8c
Compare
jianghaolu
pushed a commit
that referenced
this pull request
Sep 3, 2019
…zure#4712) Batch 2 Rule # 5 Service client methods: All methods that are in a class annotated with @ServiceClient, where the method has a @ServiceMethod annotation, should follow these rules: Methods names should follow a common vocabulary. Refer to Java spec for this naming pattern https://azure.github.io/azure-sdk/java_design.html. Method names imply certain rules around expected return type - these should all be validated. Methods should not have 'Async' added to their method name. Return types of async and sync clients should be as per guidelines: [this check will be ignored for now since I am still struggling on how to get the Reflection working in the code-quality-check] Return type for async collection should be of type ? extends PagedFlux Return type for async single value should be of type ? extends Mono Return type for sync collection should be of type ? extends PagedIterable Return type for sync single value should be of type ? extends Response Rule # 10 'withResponse' naming pattern: All methods annotated with @ServiceMethod that return a Response (or Mono) must have their method name end with 'withResponse'. If the service method does not return a Response or Mono, it must not end with 'withResponse'. Batch 3 Rule # 1 Context in all the right places: Context should be passed in as an argument to all public methods annotated with @ServiceMethod that return Response in sync clients. Only in the sync case: E.g. we want this: Public Response getFooWithResponse(int x, int y, Context c) In the async case, we should check to ensure we have no service methods that take Context! Rule # 6 Async client should have async = true property set in @ServiceClient annotation To validate this, if the class has @ServiceClient annotation and if the classname AsyncClient, verify that the async property of @ServiceClient annotation is set to true. Similarly, if the class has @ServiceClient annotation and if the classname is Client, verify that the async property of @ServiceClient annotation is set to false Change class Context to be final
jianghaolu
pushed a commit
that referenced
this pull request
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.