-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler error with Node v0.12.0 #38
Comments
I am too facing this issue.... |
Having the same issue here |
same issue... |
Same issue on Mac OS 10.9. The end of my log looks like: ../src/node-curl.h:127:10: error: no member named 'MakeWeak' in npm ERR! node-curl@0.3.3 install: |
Whole log here: https://gist.github.com/anonymous/c6746ec99527318b4eb7 |
Same issue here. |
+1 |
1 similar comment
+1 |
Is there a solution to this error? |
+1 ! |
The code above needs a fairly healthy upgrade rewrite. V8 has changed the way function callbacks work In Node v0.10, you write: v8::Handle<v8::Value> FortyTwo(const v8::Arguments& args) {
v8::HandleScope handle_scope;
return handle_scope.Close(v8::Integer::New(42));
} In Node v0.12, you write: void FortyTwo(const v8::FunctionCallbackInfo<v8::Value>& info) {
// Don't need a HandleScope in this particular example.
info.GetReturnValue().Set(42);
} results no longer return from the function but are set on the args with .GetReturnValue().Set(instance); |
Same on iojs 1.8.1 |
Same problem with digitalocean nodejs built |
Hi @rimmartin , do you know how to fix it for node-curl? I can do a PR if you can point me to the changes (I am not familiar at node-curl logic) |
Are you looking for the compare? I have a friend who is familar with github I can ask what would be the procedure. Maybe you'd have to fork and address the merge before it goes back to the main branch as a pull request |
+1 does anyone know solution for this error? |
@tarek-salah |
+1 ... anyone know the status of this issue/fork/merging? |
Delete this project or pass ownership to someone else if you aren't going to maintain it. |
Agreed... PLEASE do something with this project or pass it on to someone else. |
|
I couldn't wait around for this to be fixed, so I created my own Promise wrapper around command-line curl to do what I needed it to do. In case anyone else finds it useful, I've uploaded it as a gist. |
Okay thanks. I was looking for a fork but didn't find one. node-libcurl Wyatt On Tue, Sep 15, 2015 at 4:31 PM James Sinclair notifications@github.com
|
I get a whole bunch of errors when attempting to install with Node v0.12.0 OSX Yosemite. Is anyone else seeing these? To my untrained eye, it looks as if an update to V8 has broken things.
The text was updated successfully, but these errors were encountered: