Fixed the problem of generating wrong formula caused by RemoveCol

jianxinhou · Apr 18, 2024 · 48fb4a5 · 48fb4a5
1 parent 3e636ae
commit 48fb4a5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/datavalidation.go b/datavalidation.go
@@ -76,11 +76,13 @@ var (
 		`&`, `&amp;`,
 		`<`, `&lt;`,
 		`>`, `&gt;`,
+		`"`, "&quot;",
 	)
 	formulaUnescaper = strings.NewReplacer(
 		`&amp;`, `&`,
 		`&lt;`, `<`,
 		`&gt;`, `>`,
+		"&quot;", `"`,
 	)
 	// dataValidationTypeMap defined supported data validation types.
 	dataValidationTypeMap = map[DataValidationType]string{

diff --git a/datavalidation_test.go b/datavalidation_test.go
@@ -84,7 +84,7 @@ func TestDataValidation(t *testing.T) {
 		assert.NotEqual(t, "", dv.Formula1,
 			"Formula1 should not be empty for valid input %v", listValid)
 	}
-	assert.Equal(t, `"A&lt;,B&gt;,C"",D	,E',F"`, dv.Formula1)
+	assert.Equal(t, `"A&lt;,B&gt;,C&quot;,D	,E',F"`, dv.Formula1)
 	assert.NoError(t, f.AddDataValidation("Sheet1", dv))
 
 	dataValidations, err = f.GetDataValidations("Sheet1")