Skip to content

Commit

Permalink
[KYUUBI apache#6428] kyuubi-server/web-ui should not to set a timeout…
Browse files Browse the repository at this point in the history
… for axios requests

# 🔍 Description
## Issue References 🔗

This pull request fixes apache#6428

## Describe Your Solution 🔧

Remove axios request timeout limitation.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

Ref to apache#6428 description.

#### Behavior With This Pull Request 🎉

Get result after a period of time.

#### Related Unit Tests

kyuubi-server/web-ui: `pnpm test` all passed.

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6429 from zRains/remove-axios-timeout.

Closes apache#6428

e947dea [zRain] fix: remove timeout

Authored-by: zRain <2296342883@qq.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
  • Loading branch information
zRains authored and pan3793 committed May 30, 2024
1 parent 1e08064 commit 471237b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions kyuubi-server/web-ui/src/utils/request.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@ import { useAuthStore } from '@/pinia/auth/auth'

// create an axios instance
const service = axios.create({
baseURL: '/', // url = base url + request url
baseURL: '/' // url = base url + request url
// withCredentials: true, // send cookies when cross-domain requests
timeout: 60000 // request timeout
})

// request interceptor
Expand Down

0 comments on commit 471237b

Please sign in to comment.