test(app): response status

jiawei397 · Oct 18, 2023 · 0d7e12d · 0d7e12d
1 parent 0ade12b
commit 0d7e12d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/modules/oak/src/request.ts b/modules/oak/src/request.ts
@@ -115,7 +115,7 @@ export class NestRequest implements Request {
    * Get a specific cookie value
    */
   cookie(name: string): Promise<string | undefined> {
-    return this.originalContext.cookies.get(name) || undefined;
+    return this.originalContext.cookies.get(name);
   }
 
   /**

diff --git a/tests/app_helper.ts b/tests/app_helper.ts
@@ -950,6 +950,9 @@ export function createCommonTests(
         assertEquals(url.pathname, baseURL.pathname);
         assert(await req.text() === "");
         res.body = "hello world";
+        assertEquals(res.statusText, "OK");
+        const originResponse = res.getOriginalResponse();
+        assertNotEquals(originResponse, res);
       });
 
       const res = await fetch(`${baseUrl}`);
@@ -977,6 +980,7 @@ export function createCommonTests(
         assertEquals(req.queries("c"), []);
         assertEquals(req.query("a"), "1");
         assertEquals(req.query("b"), "2");
+        assert(!req.query("c"));
 
         const originalRequest = await req.getOriginalRequest();
         assertNotStrictEquals(originalRequest, req);
@@ -1023,12 +1027,14 @@ export function createCommonTests(
         assertEquals(await req.cookies(), { a: "1", b: "2" });
         assertEquals(await req.cookie("a"), "1");
         assertEquals(await req.cookie("b"), "2");
+        assert(!await req.cookie("c"));
 
         const headers = req.headers();
         assertEquals(headers.a, "3");
         assertEquals(headers.b, "4");
         assertEquals(req.header("a"), "3");
         assertEquals(req.header("b"), "4");
+        assert(!req.header("c"));
 
         res.body = "hello world";
       });