This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Fix parsing bug where SYSTEM_TRUSTED and SECONDARY_TRUSTED were always parsed as true #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhang0
approved these changes
Jun 29, 2018
|
Thanks. I didn't think to check other places, as this is the only place it affected me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYSTEM_TRUSTED and SECONDARY_TRUSTED are being incorrectly parsed, so that they are always set to "1".
For instance, if d.getVar("IMA", True) or d.getVar("MODSIGN", True) looks as though it should return false, if both IMA and MODSIGN != "0". However, SYSTEM_TRUSTED is set to "1" instead of "0".
Doing an explicit check of '== 1' fixes this, at the expense of looking ugly. I have tested the opposite; making sure that when the result should be true, the variables are set to 1, and this works as before.