Correctly detect lack of /bin/tar #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The higher-precedence not was applying to the expression as a whole, rather than the first component. This was causing breakage when using $PREFER_BIN on a system without a tar command (such as Windows typically is), such as in the installer for Alien::wxWidgets. The high-precedence first meant that the check for the tar command was passing when it should fail, and second that a later failing check (for example when gzip also isn't found) had its error message inverted to the empty string.
bingos
added a commit
that referenced
this pull request
Nov 30, 2012
Correctly detect lack of /bin/tar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The higher-precedence not was applying to the expression as a whole,
rather than the first component.
This was causing breakage when using $PREFER_BIN on a system without a tar
command (such as Windows typically is), such as in the installer for
Alien::wxWidgets.
The high-precedence first meant that the check for the tar command was
passing when it should fail, and second that a later failing check (for
example when gzip also isn't found) had its error message inverted to the
empty string.