Quote arguments to check.sh #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this quoting, arguments would get expanded before being passed
to bash, which would cause the following configuration to fail:
clang-format-version: 12
check-path: '.'
exclude-regex: '(foo|bar)'
because `check.sh` would get run as:
check.sh 12 . LLVM (foo|bar)
And since '(' and '|' are special characters for bash, the action will
immediately fail because of a syntax error.
Instead, it should get ran as:
check.sh "12" "." "LLVM" "(foo|bar)"
jidicula
force-pushed
the
jw/fix-quotes
branch
from
41bed8a
to
45d9a75
Compare
jidicula
reviewed
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguments would get expanded before being passed to bash, which would cause the following configuration to fail:
because
check.shwould get run as:And since '(' and '|' are special characters for bash, the action will immediately fail because of a syntax error.
Instead, it should get ran as:
This should also ensure that
check-pathworks with paths containing spaces.