Leaflet 1.1.0

[jjimenezshaw]

Migration to leaflet 1.1.0. :

• Change dependency in package.json?
• Use include instead of extend with L.Map. Was not working in 1.1.0 (see https://github.com/Leaflet/Leaflet/blob/master/PLUGIN-GUIDE.md#plugin-api)
• Remove click event call, due to fix Stop map on drag start instead of pointer down Leaflet/Leaflet#5378
• Grrrr. Rename L.Util.offsetHelper into L.Sync.offsetHelper. I was not able to extend L.Util
• BTW, fix shake after drag (with inertia) and zoom in Firefox (also in 1.0.3)
• Use leaflet 1.1.0 in examples

Tip to see the different version in a map: The minus character in the zoom control Leaflet/Leaflet#5501

[jjimenezshaw]

Just adding a function to L.Util does not work in my Ubuntu Chrome (I have not tested in other browsers). Any idea how to do it? The only option I see is to include it directly in L, not in L.Util, but it breaks backwards compatibility 😞

[jieter]

I think this is due to Leaflet's new rollup built system. I think moving it out of the utils again is the way to fix this.
Hmm, I'd say no to L.offsethelper, can't we do L.sync.offsetHelper, that would be better thanp putting it in the global L.

[jjimenezshaw]

What about this approach?

[jieter]

Looks good.

[jieter]

We also need to update the readme to state that this version and greater will support leaflet 1.1.0 and greater.
And maybe also a note in the current readme before we merge this.

Apart from that, it looks good.

[jjimenezshaw]

Could you do the note in the current readme before we merge this? Thanks.

[jieter]

Yes, I'll do that, probably tomorrow.

[jieter]

Just added the comment to the readme.

[jjimenezshaw]

Grrrr. I found a new bug that happens in Firefox (and IE) 😞 . Unfortunately I use mainly/only Chrome. It makes a strange shake when you drag the map and then zoom in (and sometimes out) with the wheel or zoom control (+/-).
It happens also in with Leaflet 1.0.3.
I will do a pull request for 1.0.3 with a workaround, before this one for 1.1.0. It is not perfect, but improves a lot this behaviour. Ok?

[jieter]

By all means, please do!

…

On 3 Jul 2017, at 21:57, Javier Jimenez Shaw ***@***.***> wrote: Grrrr. I found a new bug that happens in Firefox (and IE) 😞 . Unfortunately I use mainly/only Chrome. It makes a strange shake when you drag the map and then zoom in (and sometimes out) with the wheel or zoom control (+/-). It happens also in with Leaflet 1.0.3. I will do a pull request for 1.0.3 with a workaround, before this one for 1.1.0. It is not perfect, but improves a lot this behaviour. Ok? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#45 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZvtUHxkCjeNKSItFF8kU1YPKBSkcyLks5sKUfEgaJpZM4OKUxF>.

[jjimenezshaw]

This is interesting: the changes I have done to fix this shake or flicker in Firefox when zooming after drag (with inertia), make it compatible between 1.0.3 and 1.1.0 (we do not need onclick anymore, but we trigger the setView on moveend after a drag.). Good news.
(this change implies keeping state between events, that is not very nice... but I don't see a nicer way)
I am still testing in detail in different browsers/devices, searching for more corner cases.

I understand that package.json should have "leaflet": "^1.0.3", but what about the examples? What should I say in README.md?

[jjimenezshaw]

@jieter I think I have done all needed for the migration to 1.1.0, fixing the bug discovered in Firefox, and being compatible with both 1.0.3 and 1.1.0.

[jieter]

Nice work! I'll merge and release next week when I'm back home

[jjimenezshaw]

Thanks. (#47 will probably conflict with this PR.)

[jieter]

@jjimenezshaw merged, thanks!

released 0.2.0