Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to get_context_data #895

Merged
merged 1 commit into from Feb 25, 2023
Merged

Add type hints to get_context_data #895

merged 1 commit into from Feb 25, 2023

Conversation

mschoettle
Copy link
Contributor

I used Dict[...] instead of dict[...] since that requires Python 3.10.

Fixes #894

@jieter jieter changed the title add type hints to get_context_data Add type hints to get_context_data Feb 25, 2023
jieter
jieter approved these changes Feb 25, 2023
View reviewed changes
Copy link
Owner

@jieter jieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieter jieter merged commit d6eeb14 into jieter:master Feb 25, 2023
@mschoettle mschoettle deleted the 894-add-type-hints branch February 25, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieter jieter jieter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing type hints
2 participants
@mschoettle @jieter