Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity not working #17

Closed
mdboom opened this issue Sep 24, 2012 · 6 comments
Closed

Interactivity not working #17

mdboom opened this issue Sep 24, 2012 · 6 comments
Labels

Comments

@mdboom
Copy link

mdboom commented Sep 24, 2012

Cool idea guys.

I can click on rings of the graph and the graph updates. However, hovering does not display any information about what function is associated with the ring. Clicking on rows in the table appears to not update anything either.

I've generated a simple profile with this script:

import time

def other_function():
    time.sleep(0.01)

def function():
    time.sleep(0.1)
    for i in range(10):
        other_function()

def main():
    for i in range(15):
        function()


if __name__ == '__main__':
    main()

and then generate profile data with

python -m cProfile -o output.prf profile.py

and then start snakeviz with

snakeviz output.prf
@mdboom
Copy link
Author

mdboom commented Sep 24, 2012

I should add: I've tested on Chrome 22.0 and Firefox 15.0 on Fedora 17 Linux with the same results.

jiffyclub added a commit that referenced this issue Sep 30, 2012
…ackage_data list. This was causing the problems seen in #17.
@jiffyclub
Copy link
Owner

I tracked this down to the package_data list in setup.py having some inaccurate/missing paths so a couple JavaScript files weren't being installed (and neither were the bootstrap icons). Should be fixed with the changes in 7c6898b.

@iguananaut, can you put a 0.1.1 release up on PyPI?

@embray
Copy link
Collaborator

embray commented Oct 1, 2012

Damn--I thought I checked the contents of the source tarball pretty carefully to make sure everything was there too. But I think I was pretty tired. I'll do that in a few.

@embray
Copy link
Collaborator

embray commented Oct 1, 2012

Released v0.1.1: http://pypi.python.org/pypi/snakeviz/0.1.1 I'll leave this ticket open until it's been tested though. It works for me, but I thought that last time too :)

@jiffyclub
Copy link
Owner

I think everything was making it into the tarball because the MANIFEST.in was correct, but it wasn't being installed because package_data was incorrect. This is the peril of using setup.py develop mode.

@embray
Copy link
Collaborator

embray commented Oct 14, 2014

Yeah, I've started making setup.py sdist and pip install from the sdist into a virtualenv part of every release procedure or else there's no way to catch these things :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants