Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement coding standards with Rubocop #48

Closed
jigarius opened this issue May 24, 2019 · 1 comment
Closed

Implement coding standards with Rubocop #48

jigarius opened this issue May 24, 2019 · 1 comment
Assignees
@jigarius
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jigarius
Copy link
Owner

Create a .robocop.yml file and implement coding standards.
@jigarius jigarius added enhancement New feature or request good first issue Good for newcomers labels May 24, 2019
@jigarius jigarius self-assigned this May 24, 2019
jigarius added a commit that referenced this issue May 24, 2019
@jigarius
Run rubocop and create a .rubocop.yml file; #48
e52c2cb
jigarius added a commit that referenced this issue May 24, 2019
@jigarius
Remove unused 'tests' directory; #48
f709a6a
jigarius added a commit that referenced this issue May 24, 2019
@jigarius
Fix Style/Documentation offences; #48
7fa00ee
jigarius added a commit that referenced this issue May 24, 2019
@jigarius
Fix Metrics/ClassLength offences; #48
6889a61
jigarius added a commit that referenced this issue May 24, 2019
@jigarius
Fix Lint/DuplicateMethods offences; #48
8e6c856
jigarius added a commit that referenced this issue May 24, 2019
@jigarius
Fix Layout/ConditionPosition offences; #48
b4a2ae7
jigarius added a commit that referenced this issue May 25, 2019
@jigarius
Fix Style/CaseEquality offences; #48
307cc52
jigarius added a commit that referenced this issue May 25, 2019
@jigarius
Fix Naming/MethodName offences; #48
744a32f
jigarius added a commit that referenced this issue May 25, 2019
@jigarius
Fix Lint/NonLocalExitFromIterator offences; #48
355a618
jigarius added a commit that referenced this issue May 25, 2019
@jigarius
WIP: Fix Metrics/LineLength offences; #48
6d0f21e
jigarius added a commit that referenced this issue May 25, 2019
@jigarius
Fix Metrics/MethodLength offences; #48
1392764
jigarius added a commit that referenced this issue May 25, 2019
@jigarius
Create TODO for fixing Metrics/CyclomaticComplexity; #48
e13dcb8
jigarius added a commit that referenced this issue May 25, 2019
@jigarius
Fix Style/GuardClause offences and remove repeated code; #48
36773cb
jigarius added a commit that referenced this issue May 25, 2019
@jigarius
Fix Metrics/LineLength offences; #48
ba70812 
Move long strings into locales configuration.
jigarius added a commit that referenced this issue May 25, 2019
@jigarius
Cleanup and simplification; #48
8d856da
jigarius added a commit that referenced this issue May 25, 2019
@jigarius
Remove rubocop_todo.yml; #48
4403431
jigarius added a commit that referenced this issue Oct 3, 2019
@jigarius
refs #48: Fix various Robocop offences.
eaea2cc
jigarius added a commit that referenced this issue Oct 3, 2019
@jigarius
refs #48: Run rubocop with Travis.
8cf7a31
jigarius added a commit that referenced this issue Oct 3, 2019
@jigarius
refs #48: Run rubocop with Travis.
6484a91
jigarius added a commit that referenced this issue Oct 3, 2019
@jigarius
refs #48: Fix Style/IfUnlessModifier offences.
7929230
@jigarius
Copy link
Owner Author

jigarius commented Oct 3, 2019

Here's what I did for this one:

  • Created .rubocop.yml with some exceptions.
  • Setup automated rubocop tests with Travis.

@jigarius jigarius closed this as completed Oct 3, 2019
jigarius added a commit that referenced this issue Oct 3, 2019
@jigarius
refs #48: Fix various Robocop offences.
7b09fe6
jigarius added a commit that referenced this issue Oct 3, 2019
@jigarius
refs #48: Run rubocop with Travis.
9b3295e
jigarius added a commit that referenced this issue Oct 3, 2019
@jigarius
refs #48: Fix Style/IfUnlessModifier offences.
8d0eccb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jigarius jigarius

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jigarius