Skip to content

Commit

Permalink
[deploy-ios] fix: 디버그 빌드에서만 flipper 사용하도록
Browse files Browse the repository at this point in the history
- 빌드 오류 수정
- facebook/react-native#33764
  • Loading branch information
jiggag committed Jun 1, 2022
1 parent 95edc77 commit bfd0f2f
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ jobs:
cp $PP_PATH ~/Library/MobileDevice/Provisioning\ Profiles
- name: Install pod
run: yarn pod
run: yarn pod-release

- name: Deploy
run: cd ios && bundle exec fastlane beta && cd ..
6 changes: 5 additions & 1 deletion ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ install! 'cocoapods', :deterministic_uuids => false
target 'RNStarter' do
config = use_native_modules!

flipper_enabled = ENV['USE_FLIPPER']

use_react_native!(
:path => config[:reactNativePath],
# to enable hermes on iOS, change `false` to `true` and then install pods
Expand All @@ -26,7 +28,9 @@ target 'RNStarter' do
#
# Note that if you have use_frameworks! enabled, Flipper will not work and
# you should disable the next line.
use_flipper!({ 'Flipper' => '0.129.0' })
if flipper_enabled
use_flipper!({ 'Flipper' => '0.129.0' })
end

post_install do |installer|
react_native_post_install(installer)
Expand Down
2 changes: 1 addition & 1 deletion ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,6 @@ SPEC CHECKSUMS:
Yoga: 17cd9a50243093b547c1e539c749928dd68152da
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

PODFILE CHECKSUM: a0cb9f6fd37872f4fecf5ce5eda776e4d264427f
PODFILE CHECKSUM: a52e65ff797fbe663fb2242e099be3f6a437f044

COCOAPODS: 1.11.3
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
"test": "jest --coverage",
"lint": "eslint . --ext .js,.ts,.tsx --fix",
"reinstall": "rm -rf node_modules && yarn install",
"pod": "cd ios && USE_FABRIC=1 RCT_NEW_ARCH_ENABLED=1 pod install && cd .."
"pod": "cd ios && USE_FABRIC=1 RCT_NEW_ARCH_ENABLED=1 USE_FLIPPER=1 pod install && cd ..",
"pod-release": "cd ios && USE_FABRIC=1 RCT_NEW_ARCH_ENABLED=1 USE_FLIPPER=0 pod install && cd .."
},
"dependencies": {
"@notifee/react-native": "^4.0.1",
Expand Down

0 comments on commit bfd0f2f

Please sign in to comment.