Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

fix problem of atan function when PARSE2NUMBER is true #414

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

yosuke
Copy link
Contributor

@yosuke yosuke commented Nov 16, 2018

This patch will fix the minor problem exist in atan function, which returns undefined variable when PARSE2NUMBER is true and argument is variable.

Before:

> nerdamer.getCore().Settings.PARSE2NUMBER = true;
> nerdamer('atan(x)').text();
TypeError: Cannot read property 'text_' of undefined
    at Expression.text (/home/yosuke/nerdamer/nerdamer.core.js:1853:28)

After:

> nerdamer.getCore().Settings.PARSE2NUMBER = true;
> nerdamer('atan(x)').text()
'atan(x)'

@jiggzson
Copy link
Owner

@yosuke, thanks!

@jiggzson jiggzson merged commit 493dd68 into jiggzson:dev Nov 16, 2018
@yosuke yosuke deleted the atan_on_parse2number_equals_true branch November 16, 2018 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants