Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update engines. #18

Merged
merged 2 commits into from
May 1, 2023
Merged

Update engines. #18

merged 2 commits into from
May 1, 2023

Conversation

mvaled
Copy link
Contributor

@mvaled mvaled commented Apr 17, 2023

I'm trying to add this in a new project, but fails because my node version is 19.

@jihchi
Copy link
Owner

jihchi commented Apr 17, 2023

Thanks for the PR.

Could you please elaborate on the error you experienced? Were there any error messages you received?

@mvaled
Copy link
Contributor Author

mvaled commented Apr 19, 2023

@jihchi When I try to add it to my project with yarn add -D @jihchi/vite-plugin-react it fails because I'm using node 19.

@mvaled
Copy link
Contributor Author

mvaled commented Apr 21, 2023

@jihchi This is the exact error:

$ yarn add -D @jihchi/vite-plugin-rescript                                                                                                                                                                                         
yarn add v1.22.19
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
error @jihchi/vite-plugin-rescript@5.1.0: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^18". Got "19.8.1"
warning @jihchi/vite-plugin-rescript@5.1.0: The engine "pnpm" appears to be invalid.
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

Copy link
Owner

@jihchi jihchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed the version of pnpm directly, we can exclude it in this PR.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
jihchi
jihchi previously approved these changes Apr 23, 2023
Copy link
Owner

@jihchi jihchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for the contribution.

@jihchi jihchi merged commit ceaa3af into jihchi:main May 1, 2023
@mvaled mvaled deleted the node-19 branch May 1, 2023 06:57
@mvaled
Copy link
Contributor Author

mvaled commented May 11, 2023

Hi @jihchi

Do you plan to make a release soon?

@jihchi
Copy link
Owner

jihchi commented May 11, 2023

@mvaled Yes, here is the new release: @jihchi/vite-plugin-rescript@5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants