Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scout] Add alternative titles to search index #235

Closed
pushrbx opened this issue Jun 6, 2022 · 2 comments · Fixed by #412
Closed

[Scout] Add alternative titles to search index #235

pushrbx opened this issue Jun 6, 2022 · 2 comments · Fixed by #412
Assignees
Milestone

Comments

@pushrbx
Copy link
Collaborator

pushrbx commented Jun 6, 2022

Related to #189 and #227

jikan/#397 mentions the need for alternative titles in responses, which I think also implies that people would want to search for documents with them too.

@pushrbx pushrbx self-assigned this Jun 6, 2022
@irfan-dahir
Copy link
Contributor

To update/note here (reference #227)

We'll start by indexing only Title, Title English, and Title Japanese.

We can include other languages in the search such as synonyms, german, french, etc (available on MAL) post-merge of #227 and further tweaking/testing.

@irfan-dahir irfan-dahir changed the title Add alternative titles to search index [Scout] Add alternative titles to search index Oct 7, 2022
@pushrbx pushrbx added this to the v4.0.1 milestone Oct 30, 2022
@pushrbx
Copy link
Collaborator Author

pushrbx commented Jun 27, 2023

This one is still missing. We already have the data in the database in the titles attribute, which should be indexed by flattening all the titles in a string array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants