Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/adds reviews dtos #422

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Bugfix/adds reviews dtos #422

merged 3 commits into from
Jul 13, 2023

Conversation

irfan-dahir
Copy link
Contributor

  • Adds HasSpoilerParameter and HasPreliminaryParameter for Anime/Manga Reviews and Recent Reviews
  • Adds documentation for spoilers and preliminary to both endpoints

@irfan-dahir irfan-dahir requested a review from a team as a code owner July 9, 2023 16:24
@majora2007 majora2007 mentioned this pull request Jul 10, 2023
Closed
pushrbx
pushrbx approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@pushrbx pushrbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty and refactored dtos which already had the preliminary and spoilers parameters to use the newly added traits. 🐱

LGTM

@irfan-dahir irfan-dahir merged commit ace6cf3 into master Jul 13, 2023
@irfan-dahir irfan-dahir deleted the bugfix/adds-reviews-dtos branch July 13, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pushrbx pushrbx pushrbx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irfan-dahir @pushrbx