Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename genre to genres on manga endpoint #35

Closed
doron-goldstein opened this issue Jun 20, 2017 · 5 comments
Closed

Rename genre to genres on manga endpoint #35

doron-goldstein opened this issue Jun 20, 2017 · 5 comments
Assignees

Comments

@doron-goldstein
Copy link

Anime uses genres, so I thought it would be nicer to have it uniform and name it genres in Manga as well. (already made my code fail once haha)

@irfan-dahir
Copy link
Collaborator

irfan-dahir commented Jun 20, 2017

Oops, this is embarrassing. Sorry about this!

I've removed multiple suffixes of the use of 's' after some array type elements. Such as 'authors' -> 'author' and 'genres' -> 'genre' since the 0.2.3 alpha (June 2, 17) source.

It seems I've forgotten to unify it for some 'endpoints'. I'll be releasing a patch for this today.

It'll be 'genre' from now for both anime and manga. :)

@doron-goldstein
Copy link
Author

Ah I see. Thanks!

@irfan-dahir
Copy link
Collaborator

irfan-dahir commented Jun 21, 2017

I've just released patch 0.2.6 for it.

Read this for the changes.
https://github.com/irfan-dahir/jikan#026-beta---june-21-17

@doron-goldstein
Copy link
Author

actually, @irfan-dahir it seems anime still uses 'genres'.

@irfan-dahir
Copy link
Collaborator

irfan-dahir commented Jun 21, 2017

@BlackSynder Ah, that's the cache. I've cleared it so it should be updated one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants