Skip to content

Commit

Permalink
Use contextlib.closing around cwop socket
Browse files Browse the repository at this point in the history
Signed-off-by: Jim Easterbrook <jim@jim-easterbrook.me.uk>
  • Loading branch information
jim-easterbrook committed Aug 29, 2018
1 parent 0dfa5e2 commit b8d4f8e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 13 deletions.
4 changes: 2 additions & 2 deletions src/pywws/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
__version__ = '18.8.0'
_release = '1609'
_commit = 'a46178b'
_release = '1610'
_commit = '0dfa5e2'
19 changes: 8 additions & 11 deletions src/pywws/service/cwop.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@

from __future__ import absolute_import, print_function, unicode_literals

from contextlib import contextmanager
from contextlib import closing, contextmanager
from datetime import timedelta
import logging
import os
Expand Down Expand Up @@ -98,17 +98,14 @@ class ToService(pywws.service.LiveDataService):

@contextmanager
def session(self):
session = socket.socket()
session.settimeout(20)
server = ('rotate.aprs.net',
'cwop.aprs.net')[self.fixed_data['passcode'] == '-1']
session.connect((server, 14580))
response = session.recv(4096)
logger.debug('server software: %s', response.strip())
try:
with closing(socket.socket()) as session:
session.settimeout(20)
server = ('rotate.aprs.net',
'cwop.aprs.net')[self.fixed_data['passcode'] == '-1']
session.connect((server, 14580))
response = session.recv(4096)
logger.debug('server software: %s', response.strip())
yield session
finally:
session.close()

def upload_data(self, session, prepared_data={}, live=False):
login = ('user {designator:s} pass {passcode:s} ' +
Expand Down

0 comments on commit b8d4f8e

Please sign in to comment.