Elvis #6
Open
Elvis #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TicTacToe/App.fs
Outdated
|
|
||
| match anyMoreMoves model with | ||
| | true -> StillPlaying | ||
| | false -> Draw |
TicTacToe/App.fs
Outdated
| /// A helper to get the suffix used in the Xaml for a position on the board. | ||
| let uiText (row,col) = | ||
| (match row with 0 -> "T" | 1 -> "M" | 2 -> "B" | _ -> failwith "huh?") + | ||
| (match col with 0 -> "L" | 1 -> "C" | 2 -> "R" | _ -> failwith "huh?") |
There was a problem hiding this comment.
It's pity we loose safety here :( Yes, it's boiler-free, but...
TicTacToe/App.fs
Outdated
| | Empty -> | ||
| match getGameResult model with | ||
| | StillPlaying -> true | ||
| | _ -> false |
There was a problem hiding this comment.
getGameResult model = StillPlaying?
|
@vasily-kirichenko Thanks for the feedback! I pushed some further updates |
The changes read much better... but what is an "Elvis" F# programmer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the additional changes including the more basic cleanup #5 to make the UI more programmatic in the way that an "Elvis" F# programmer would do it. I think the code in master is right for beginners. Then show this transition.