A proper test suite #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 31, 2012 09:32
…onality is improved
|
|
||
| class Wrapper | ||
| { | ||
| protected $output = ''; | ||
| protected $currentPosition = 0; | ||
|
|
||
| protected static $overrideWrappers = array('http', 'https'); | ||
| public static $overrideWrappers = array('http', 'https'); |
There was a problem hiding this comment.
remind me why this is public again?
There was a problem hiding this comment.
It is intended to allow the user more flexibility in what they choose to mock. I will implement a getter and setter for this instead.
|
Tests looked solid, made a few minor comments. Take a look before I merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few small changes to the actual Spray code, but this pull is mostly to give Spray a proper test suite