Update for newer ES features #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change var to const and let. - Change arrays to spread syntax. - Change to arrow functions.
- Change var to const in the usage guidelines.
- Require node 6 at a minimum to support the newer ES features. Node version functionality determined via https://node.green. - Update dev dependencies to their latest versions. Mocha 3.4 relied on a version of growl with a known vulnerability. - Fix the keywords section, this field is actually an array. - Update eslint syntax to ES6.
- Add the package-lock.json file to the repository to ensure consistent builds.
- Add additional node versions for Travis to test. - Change var to const in mocha JS file.
- Update version number to 2.0.0 since changes affect backwards compatibility with node v4. - Update Travis config to allow node module caching.
|
Thanks for this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I forked your repo to serve as a base for a base 56 node module. I made some updates to use newer ES6 features and also to update the dependencies; thought you might want the changes.
All the tests pass locally and Travis tests pass with node 6 to current.