Change reporting of lints in GHA #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it make sense to extend this test to match the new expected format? Happy to merge anyway |
|
I would probably leave this as is. When/if you update for testthat 3rd edition, this will become (or gain) a snapshot test anyway. So you won't have to hardwire your exact expectation, you'll just capture "good output" once and be alerted if things change. Also this doesn't seem like a particularly tricky or high risk bit of code. |
MichaelChirico
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #558
Reports the linting via a GHA annotation (a warning) but also puts file and line details into the log