New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devDependencies for karma and jasmine #57
Comments
Yeah, I agree. Jasmine 2.0 is much better than 1.3. There are about 1,000 tests at the moment though and this is quite a lot of work for something which hasn't in the past created any practical problems. I just made a fresh clone and npm install worked ok. Does this not work for you? Peer dependencies are always tricky but old versions should still work with packages from the same era. |
When I cloned and did an npm install, I ran into the issues outlined above. There are definitely a lot of tests, but I've realized that it's the same On Sat, Jan 10, 2015 at 11:39 AM, Jim Higson notifications@github.com
|
That's awesome. Let me know how you get on and if anything isn't very obvious how to convert. I don't seem to have karma globally, not sure why npm install didn't work for you, but I agree that updating the dependencies is the correct way to deal with this.
|
I do have a question, actually - are all of the tests passing in your On Sat, Jan 10, 2015 at 1:13 PM, Jim Higson notifications@github.com
|
I'm on my iPad now so can't run this moment but they were passing when I If you're getting a build failure on master please post the log On Saturday, January 10, 2015, Jedd Ahyoung notifications@github.com
|
Passing on the Ci: https://travis-ci.org/jimhigson/oboe.js |
Forking and pulling oboe.js, I attempt an
npm install
and get the following:The problem here is that we're using older versions of libraries that have since been upgraded. I was able to update
package.json
to the latest versions, like so:However, this breaks the existing tests as Jasmine has changed a lot of their conventions since the currently-used version.
Suggest updating package dependencies and updating the tests to use new Jasmine syntax.
The text was updated successfully, but these errors were encountered: