Merge pull request pokeb#211 from christophercotton/master

Cache Error with downloadDestinationPath, Not storing downloaded data
jimkang · Aug 6, 2011 · e7fff59 · e7fff59
2 parents ca6df3f + 22f1b31
commit e7fff59
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/Classes/ASIDownloadCache.m b/Classes/ASIDownloadCache.m
@@ -159,9 +159,14 @@ - (void)storeResponseForRequest:(ASIHTTPRequest *)request maxAge:(NSTimeInterval
 
 	if ([request responseData]) {
 		[[request responseData] writeToFile:dataPath atomically:NO];
-	} else if ([request downloadDestinationPath] && ![[request downloadDestinationPath] isEqualToString:dataPath]) {
+	} else if ([request downloadDestinationPath] && ![[request downloadDestinationPath] isEqualToString:dataPath]) {        
 		NSError *error = nil;
-		[[[[NSFileManager alloc] init] autorelease] copyItemAtPath:[request downloadDestinationPath] toPath:dataPath error:&error];
+        NSFileManager* manager = [[NSFileManager alloc] init];
+        if ([manager fileExistsAtPath:dataPath]) {
+            [manager removeItemAtPath:dataPath error:&error];
+        }
+        [manager copyItemAtPath:[request downloadDestinationPath] toPath:dataPath error:&error];
+        [manager release];
 	}
 	[[self accessLock] unlock];
 }