Code Sniffed!

jimlind · Sep 7, 2015 · 3afabb0 · 3afabb0
1 parent f46535f
commit 3afabb0
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/src/JimLind/TiVo/Factory/ShowFactory.php b/src/JimLind/TiVo/Factory/ShowFactory.php
@@ -41,7 +41,8 @@ public function createShowFromXml(SimpleXMLElement $xml)
      *
      * @return mixed[]
      */
-    protected function normalizeShowXml(SimpleXMLElement $xml) {
+    protected function normalizeShowXml(SimpleXMLElement $xml)
+    {
         $urlList       = $xml->xpath('tivo:Links/tivo:Content/tivo:Url');
         $detailXml     = $xml->xpath('tivo:Details');
         $namespacedXml = $this->registerTiVoNamespace(reset($detailXml));

diff --git a/src/JimLind/TiVo/XmlDownloader.php b/src/JimLind/TiVo/XmlDownloader.php
@@ -48,7 +48,7 @@ class XmlDownloader
      */
     public function __construct($ip, $mak, ClientInterface $guzzle)
     {
-        $this->uri = (new Uri)
+        $this->uri = (new Uri())
             ->withScheme('https')
             ->withHost($ip)
             ->withPath('TiVoConnect');

diff --git a/tests/JimLind/TiVo/Characteristic/XmlTraitTest.php b/tests/JimLind/TiVo/Characteristic/XmlTraitTest.php
@@ -70,6 +70,9 @@ public function testEmptyXMLString()
     /**
      * Test XML output
      *
+     * @param string $input    Raw XML string
+     * @param string $expected Namespaced XML string
+     *
      * @dataProvider testAfterRegisterProvider
      */
     public function testAfterRegister($input, $expected)
@@ -81,6 +84,11 @@ public function testAfterRegister($input, $expected)
         $this->assertEquals($expected, $actual);
     }
 
+    /**
+     * Data provider for the after register test
+     *
+     * @return mixed[]
+     */
     public function testAfterRegisterProvider()
     {
         return [
@@ -91,7 +99,7 @@ public function testAfterRegisterProvider()
             [
                 '<x><y /></x>',
                 "<?xml version=\"1.0\"?>\n<x xmlns=\"http://www.w3.org/2001/XMLSchema\"><y/></x>\n",
-            ]
+            ],
         ];
     }
 }
diff --git a/tests/JimLind/TiVo/VideoDownloaderTest.php b/tests/JimLind/TiVo/VideoDownloaderTest.php
@@ -79,6 +79,9 @@ public function testFilePathPassThroughOnDownload()
     /**
      * Test the timeout is passed through to Guzzle
      *
+     * @param string $method  Download method
+     * @param int    $timeout Timeout value
+     *
      * @dataProvider testGuzzleTimeoutProvider
      */
     public function testGuzzleTimeout($method, $timeout)