Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an AbstractBase class traited with PSR3's LoggerAwareTrait #2

Merged
merged 1 commit into from
Sep 8, 2015

Conversation

frqnck
Copy link
Contributor

@frqnck frqnck commented Sep 7, 2015

Hi there,

I noticed that you are using Apix\Log =) so decided to contribute.

Hope this helps you out.

@jimlind
Copy link
Owner

jimlind commented Sep 8, 2015

Thanks 😸
I always thought that setLogger stuff might make more sense not duplicating itself, but didn't realize PSR3 took care of it.

The AbstractBase class name isn't as descriptive and I usually like so I might rename it or refactor to a trait if I can come up with a better name.

jimlind added a commit that referenced this pull request Sep 8, 2015
Adds an AbstractBase class traited with PSR3's LoggerAwareTrait
@jimlind jimlind merged commit c70eaeb into jimlind:master Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants