Use +/-/= instead of smiles. Closes #1 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'd prefer if we continue to support the smilies in addition to the new syntax for backwards compatibility. I'm also not sure how I feel about having "retro clear" functionality available for admins by default. Let's take that out of this PR and discuss that separately. Otherwise, everything looks good! |
| @@ -8,3 +8,5 @@ | |||
|
|
|||
| require "lita-retro" | |||
| require "lita/rspec" | |||
|
|
|||
| Lita.version_3_compatibility_mode = false | |||
|
@jimmycuadra fair enough, I've pushed the changes. To me it seems that chat admin should basically have all permissions by-default. It also simplifies installation and usage of this gem, as you're deferring permission adding until you really need it. |
jimmycuadra
added a commit
that referenced
this pull request
Dec 3, 2014
Use +/-/= instead of smiles. Closes #1
|
Thanks a lot! Released in v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
I gave it a thought and decided that having shorter syntax would be better - people are lazy.