Lower default lines of UD response to 5, adjust corresponding spec

[chriswoodrich]

[chriswoodrich]

This fixes issue #1

[chriswoodrich]

@jimmycuadra pls

[jimmycuadra]

I think 20 is a reasonable default, but it'd be great to expose this limit as a configuration option if people want to change it.

I also noticed that the definition that brought on this discussion was resulting in about 45 lines of response, so this PR will not address that problem – there's some other bug happening that's making it bypass this hard coded limit of 20.

[chriswoodrich]

I'll add a config ceiling and investigate the bug at the same time.

In the mean time, can you merge this to thwart @tristaneuan ?

[jimmycuadra]

It won't have any effect as is, due to the bug I mentioned. :\

[jimmycuadra]

Let's move this logic into its own method so the comment isn't needed. Use flat_map instead of map + flatten for improved performance. For style, put a space after { and before }.

[jimmycuadra]

Looking pretty good! The new option should be added to the README, as well.

[chriswoodrich]

Will do, @jimmycuadra

[jimmycuadra]

I just pushed up a commit that fixes the bug where long examples don't get truncated and adds better test coverage. That will simplify this branch. Here's what's left:

• Rebase onto the latest master.
• Remove format_lines and the call to it, since it's no longer needed.
• Don't set a default value for max_response_size. As is, if someone didn't want responses truncated, the only way to do it would be to fake it by setting the response size to a really high number, which isn't a great user interface.
• Make sure the logic handles the case where max_response_size is nil. (Add a test for this case.)
• Update the docs to reflect the lack of default value.
• Squash your commits down to one for a clean history.

Thanks! :D

[chriswoodrich]

[jimmycuadra]

lolz, my bad

[chriswoodrich]

This is better UI. Default max response is now 20 lines, hard-coding is removed giving the user more control, and a nil value of the max_response_size will not truncate responses at all. I added tests for nil and for a user-set ceiling of 10.

[webdestroya]

y u do dis? Change to if/else/end

[jimmycuadra]

Looks great. I agree with Mitch though, unless/else is a pattern to avoid. Switch that up and then I'll merge it. Thanks!!

[jimmycuadra]

Actually, I can't merge this cleanly yet. You'll have to rebase your own commits onto the latest master. git fetch upstream && git rebase upstream/master

[chriswoodrich]

Ready to go, @jimmycuadra