Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indigenous round team names not addressed using replace_teams() #215

Open
JaseZiv opened this issue May 19, 2024 · 2 comments
Open

Indigenous round team names not addressed using replace_teams() #215

JaseZiv opened this issue May 19, 2024 · 2 comments

Comments

@JaseZiv
Copy link
Contributor

JaseZiv commented May 19, 2024

AFL.com.au uses the indigenous team names for Sir Doug Nicholls round, causing downstream issues in code that joins on typical AFL team names.

packageVersion("fitzRoy")
[1] ‘1.3.0’
# obviously, this doesn't return 'Melbourne' as we'd hope:
fitzRoy::replace_teams("Narrm")
[1] "Narrm"

Additionally, the AFL randomly started using the capitalised versions of GWS and GC team nicknames (GIANTS and SUNS as opposed to Giants and Suns).

# this returns the standardised team name (as expected):
fitzRoy::replace_teams("GWS Giants")
[1] "GWS"

# while this is wrong:
fitzRoy::replace_teams("GWS GIANTS")
[1] "GWS GIANTS"

I will submit a PR for your review shortly @jimmyday12. Feel free to reject it if that function isn't intended to clean AFL.com.au team names

@jimmyday12
Copy link
Owner

Thanks for picking this up. I probably won't get a chance to review until tonight but appreciate the PR

@JaseZiv
Copy link
Contributor Author

JaseZiv commented May 19, 2024

Absolutely no rush at all.

jimmyday12 added a commit that referenced this issue May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants