You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AFL.com.au uses the indigenous team names for Sir Doug Nicholls round, causing downstream issues in code that joins on typical AFL team names.
packageVersion("fitzRoy")
[1] ‘1.3.0’
# obviously, this doesn't return 'Melbourne' as we'd hope:fitzRoy::replace_teams("Narrm")
[1] "Narrm"
Additionally, the AFL randomly started using the capitalised versions of GWS and GC team nicknames (GIANTS and SUNS as opposed to Giants and Suns).
# this returns the standardised team name (as expected):fitzRoy::replace_teams("GWS Giants")
[1] "GWS"# while this is wrong:fitzRoy::replace_teams("GWS GIANTS")
[1] "GWS GIANTS"
I will submit a PR for your review shortly @jimmyday12. Feel free to reject it if that function isn't intended to clean AFL.com.au team names
The text was updated successfully, but these errors were encountered:
AFL.com.au uses the indigenous team names for Sir Doug Nicholls round, causing downstream issues in code that joins on typical AFL team names.
Additionally, the AFL randomly started using the capitalised versions of GWS and GC team nicknames (
GIANTS
andSUNS
as opposed toGiants
andSuns
).I will submit a PR for your review shortly @jimmyday12. Feel free to reject it if that function isn't intended to clean AFL.com.au team names
The text was updated successfully, but these errors were encountered: