Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch. 1 Spelling/Grammatical Corrections #20

Closed
Jason-Les opened this issue Jun 25, 2018 · 4 comments
Closed

Ch. 1 Spelling/Grammatical Corrections #20

Jason-Les opened this issue Jun 25, 2018 · 4 comments

Comments

@Jason-Les
Copy link

Pg. 13

Think of Finite Fields as something that you could have learned in High School
instead of Trigonomotry, just that the education system you’re a part of decided that
Trigonomotry was more important for you to learn.

Trigonometry misspelled

...Elliptic Curve Cryptography. That, in turn is essential for…

Should be a comma following in turn

Pg. 14

Let’s unpack each of the following.

Should be “above” instead of “following” (since its referencing the list above) and maybe followed by a colon

We name the elements 0, 1, 2, etc because they’re convenient for our purposes.

etc should have a period at the end, "etc."

Pg 15.

If not, we got an invalid Field Element

Change got to "have" or maybe "get"

Pg. 18

After all 11+f17=9 just doesn’t look right for most people because they’re not used to Finite Field addition.

Add a comma proceeding After all. Fix the finite field addition symbol.

Pg. 21

The difference here is that the exponent is not a field element, so has to be treated a bit differently

Insert "it" after so

Pg. 25

We want, for example something like this to work:

Insert comma after for example

Pg. 26

In thes chapter we learned about Finite Fields and how to implement it in Python. We’ll be utilizing thes in Chapter 3 for Elliptic Curve Cryptography.

"This" mispelled as thes in two instances

@plazma48
Copy link

yea i put a pull request for page 26 typo of "thes" to "this" in two instance.....

@plazma48
Copy link

plazma48 commented Oct 1, 2018

nice....:-)

@smh69
Copy link

smh69 commented Nov 3, 2018

Ch1, ipynb, ex5: I suspect the exercise should be in F19 and not F97
Ch1, ipynb, ex8 : 'F 31' reads with funny subscript because '31' needs enclosing curly braces.
ecc.py: perhaps generic messages when TypeError raised would read better as 'Cannot operate on elements from different fields' rather than 'Cannot add two...' if exact operation is not part of the message. (fixed in commit 7802243)

@jimmysong
Copy link
Owner

These are all fixed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants