Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in deep-merge that turns false into nil #19

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

dominicfreeston
Copy link
Contributor

Current implementation behaviour:

(deep-merge {:x true} {:x false})
;; => {:x nil}

After the fix:

(deep-merge {:x true} {:x false})
;; => {:x false}

This is currently a problem when using clj-http and setting {:http {:throw-exceptions false}} because internally it specifically uses the false? predicate, which behaves differently for false and nil.

@jimmythompson jimmythompson merged commit d7791c8 into jimmythompson:master Jul 19, 2023
1 check passed
@dominicfreeston dominicfreeston deleted the fix-deep-merge branch July 19, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants