Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the filed name in showSaveFilePicker options #45

Merged
merged 2 commits into from
Dec 25, 2022

Conversation

garsue
Copy link
Contributor

@garsue garsue commented Dec 25, 2022

@jimmywarting
Copy link
Owner

d.ts is generated by the JSDocs.
so that should be changed instead.

@garsue
Copy link
Contributor Author

garsue commented Dec 25, 2022

After fixing JSDoc, I ran npm run _prepublishOnly and re-generated the d.ts.
As a result, unrelated files were also changed, but I committed them as well.

@jimmywarting jimmywarting merged commit 443e0fe into jimmywarting:master Dec 25, 2022
@jimmywarting
Copy link
Owner

Thanks, that's fine

@garsue garsue deleted the patch-2 branch December 26, 2022 06:36
@linonetwo
Copy link

I think showOpenFilePicker also needs to be changed #57 (comment)

And this seems not released in v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants