fix various issues with createWritable for Safari #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SargisPlusPlus
commented
Feb 8, 2024
| @@ -123,7 +124,7 @@ if ( | |||
| // So we need to pass the path to the worker. This is a bit hacky and ugly. | |||
| const root = await navigator.storage.getDirectory() | |||
| const parent = await wm.get(this) | |||
| const path = await parent.resolve(root) | |||
| const path = await root.resolve(parent) | |||
|
|
|||
| // Should likely never happen, but just in case... | |||
There was a problem hiding this comment.
it did happen :P
swapping root/parent solves it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This PR address issues found in PR62
Tested on Safari 17.2