Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad quality (JPEG Compression) when saving PNG #121

Open
super-ienien opened this issue Apr 14, 2016 · 9 comments
Open

Bad quality (JPEG Compression) when saving PNG #121

super-ienien opened this issue Apr 14, 2016 · 9 comments
Assignees
Labels
bug there is a bug in the way jimp behaves issue-in-dependency

Comments

@super-ienien
Copy link
Contributor

Hi,

I'm having some trouble with image quality on JIMP.
I just download some JPEGs and save them as PNGs :

Jimp.readAsync(url) .then(function (image) { return image.writeAsync("image.png") }

The quality of the PNG is bad comparing to the original JPEG. It's like I was saving it twice in JPEG. See the exemple here (you can see that additionnal JPEG artefacts are presents around the white letters in the PNG):

ORIGINAL JPEG
cgajreywqaewbai

SAVED PNG
image 1__media_cgajreywqaewbai

@oliver-moran
Copy link
Collaborator

These aren't methods from this library:

Jimp.readAsync(url) ... image.writeAsync ...

How are you calling them?

@super-ienien
Copy link
Contributor Author

Sorry, i'm using promisification functionnality of bluebird. So readAsync ad writeAsync are the promisified version of read and write method from Jimp.

@oliver-moran
Copy link
Collaborator

I'm doing a release in a few days. That will have some fixes in it, could you check again then?

@super-ienien
Copy link
Contributor Author

I don't have time to test it again but i think it's due to the pngjs package more than Jimp

@oliver-moran
Copy link
Collaborator

Yes, definitely to do with pngjs. I'll keep an eye on it and if there's improvement to that library I'll pull it in. Thanks for logging it.

@oliver-moran
Copy link
Collaborator

Tested again after updating pngjs. Issues still presents.

@oliver-moran
Copy link
Collaborator

oliver-moran commented Aug 10, 2016

Suspect same as this issue: #134

@hipstersmoothie
Copy link
Collaborator

still an issue

@hipstersmoothie
Copy link
Collaborator

jpeg-js/jpeg-js#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug there is a bug in the way jimp behaves issue-in-dependency
Projects
None yet
Development

No branches or pull requests

3 participants