Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'resume support' detection on FreeBSD #243

Merged
merged 1 commit into from Jul 18, 2018

Conversation

pit3k
Copy link
Contributor

@pit3k pit3k commented Jul 17, 2018

FreeBSD does not accept options at the end, so without this fix it always fails:

$ uname -sr
FreeBSD 11.2-RELEASE
$ /sbin/zfs get receive_resume_token -d 0
cannot open '-d': dataset does not exist
cannot open '0': dataset does not exist
$ /sbin/zfs get -d 0 receive_resume_token
NAME      PROPERTY              VALUE      SOURCE
newzroot  receive_resume_token  -          -

Copy link
Owner

@jimsalterjrs jimsalterjrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only changes order of arguments. Works fine either way on Linux (tested right now on Bionic workstation). I'll take your word about it fixing BSD. Approved.

@jimsalterjrs jimsalterjrs merged commit 4b32d46 into jimsalterjrs:master Jul 18, 2018
@jimsalterjrs
Copy link
Owner

Thank you for the patch, @pit3k. Merged.

@pit3k pit3k deleted the fix-resume-on-freebsd branch July 18, 2018 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants