Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed sleeping between snapshot taking #286

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

phreaker0
Copy link
Collaborator

For me sanoid runtime is down by 1/3 with a small count of datasets and the difference will only get larger for a higher dataset count.
I don't see any problem if there are snapshots with the same creation time, in the typical use case the snapshots grouped by interval type won't have the same creation time and even if the will get the same creation time anyhow it shouldn't break anything.
But maybe I overlooked something, I will run this on several machines and check if anything comes up.

@jimsalterjrs jimsalterjrs merged commit 1042414 into jimsalterjrs:master Dec 4, 2018
@jimsalterjrs
Copy link
Owner

This one made me nervous at first because back in the dawn of time, I used creation time as part of the "is this the right snapshot" checks. We should long since have changed all that to look at UIDs, though, so... ::crosses fingers::

@phreaker0 phreaker0 deleted the no-sleep branch March 24, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants