Fix interactive output #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing of error codes, this way stderr is left alone and pv can work interactively
…cation where the send size can't be estimated (in which case pv is not working anyway, so we can break the interactivitiy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396
This PR will only capture the stdout of some replication commands and leave stderr mostly untouched so pv works correctly because it's directly connected to the terminal. The zfs receive command stderr is therefore redirected to stdout for parsing.
The problem arises with zfs send, where stderr can't be redirected to stdout or else the replication stream is contaminated. There is currently only one case where and error check of zfs send is needed (resumed send where the src initial snapshot is missing) but for that case a workaround is used, exploiting that send estimation doesn't work there, we don't need pv output and therefore can capture stderr there. So this PR should fix the interactive output with PV without reverting the error detection stuff, yeah!