Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: --tags option #1

Closed
maxarndt opened this issue Apr 23, 2020 · 2 comments
Closed

Feature: --tags option #1

maxarndt opened this issue Apr 23, 2020 · 2 comments

Comments

@maxarndt
Copy link

Hey Jim!

This action looks great! Thanks so far!

I'm currently using git describe --tags in a few projects and thinking about replacing my current CI/CD solution with GitHub Actions.

Is there a chance to add the --tags option to your action?

       --tags
           Instead of using only the annotated tags, use any tag found in refs/tags namespace. This
           option enables matching a lightweight (non-annotated) tag.

Or are there any conflicts with the existing inputs of your action?

@maxarndt
Copy link
Author

I just saw that you are already using the --tags option in the Testing section of your readme.

If you draw attention to this a little earlier or more clearly, it will certainly be helpful for one or the other interested person.

Thank's for your work!

@jimschubert
Copy link
Owner

Sorry, I've just seen that you'd opened and then closed this.

I added some clarity at the top of the README that it's specifically git describe --tags underneath. See 28ed6df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants